----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66300/#review200442 -----------------------------------------------------------
Hi Dani, Thanks for fixing the issues, one last nit I found is that DerbyPolicy contains 2 new lines at the end of file so git gives a warning when you apply it, can you please fix that as well? I think we should also start thinking about when we want to commit this patch and understand the full impact of it. I think we should wait until we have a stable version of Hive 3 and you have mentioned that the ACID tables might be the default in Hive 3. Can you point us to a mail chain/wiki page/JIRA board which contains the rough timeline and the breaking changes of Hive 3? - Szabolcs Vasas On March 27, 2018, 8:50 a.m., daniel voros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66300/ > ----------------------------------------------------------- > > (Updated March 27, 2018, 8:50 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3305 > https://issues.apache.org/jira/browse/SQOOP-3305 > > > Repository: sqoop-trunk > > > Description > ------- > > To be able to eventually support the latest versions of Hive, HBase and > Accumulo, we should start by upgrading our Hadoop dependencies to 3.0.0. See > https://hadoop.apache.org/docs/r3.0.0/index.html > > > Diffs > ----- > > ivy.xml 6be4fa2 > ivy/libraries.properties c44b50b > src/java/org/apache/sqoop/SqoopOptions.java 651cebd > src/java/org/apache/sqoop/config/ConfigurationHelper.java e07a699 > src/java/org/apache/sqoop/hive/HiveImport.java c272911 > src/java/org/apache/sqoop/mapreduce/JobBase.java 6d1e049 > src/java/org/apache/sqoop/mapreduce/hcat/DerbyPolicy.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 784b5f2 > src/java/org/apache/sqoop/util/SqoopJsonUtil.java adf186b > src/test/org/apache/sqoop/TestSqoopOptions.java bb7c20d > src/test/org/apache/sqoop/util/TestSqoopJsonUtil.java fdf972c > testdata/hcatalog/conf/hive-site.xml edac7aa > > > Diff: https://reviews.apache.org/r/66300/diff/2/ > > > Testing > ------- > > Normal and third-party unit tests. > > > Thanks, > > daniel voros > >
