> On April 3, 2018, 9:13 a.m., Szabolcs Vasas wrote: > > Hi László, > > > > Thank you for submitting this improvement, it is a nice catch! > > It looks good to me however it would be great if you could create a couple > > of unit test cases to cover the code you have added. > > > > Thanks, > > Szabolcs
I'll take care of it. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66353/#review200344 ----------------------------------------------------------- On March 29, 2018, 9:10 a.m., Laszlo Bodor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66353/ > ----------------------------------------------------------- > > (Updated March 29, 2018, 9:10 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3306 > https://issues.apache.org/jira/browse/SQOOP-3306 > > > Repository: sqoop-trunk > > > Description > ------- > > A fortify scan showed 2 possible resource leaks. > > 1: The function getRecordWriter() in DBOutputFormat.java sometimes fails to > release a database resource allocated by getConnection() on line 117. > In the file DBOutputFormat.java similar issues were on line numbers 117 > > 2: The function makeConnection() in OracleManager.java sometimes fails to > release a database resource allocated by getConnection() on line 321. > In the file OracleManager.java similar issues were on line numbers 321 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/OracleManager.java 929b5061 > src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 730ff286 > > > Diff: https://reviews.apache.org/r/66353/diff/1/ > > > Testing > ------- > > ant test > > > Thanks, > > Laszlo Bodor > >
