----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61777/#review183322 -----------------------------------------------------------
Hi Zoltan, Thanks for the contribution, and thanks for adding quite a few test cases, a few nitpicks above Szabolcs' ones. Please take a look and let me know your thoughts. Thanks, Anna src/java/org/apache/sqoop/mapreduce/db/SQLServerDBRecordReader.java Line 76 (original), 89-91 (patched) <https://reviews.apache.org/r/61777/#comment259360> This comment is a little hard to understand, could you give a bit more specific example? src/java/org/apache/sqoop/mapreduce/db/SQLServerDBRecordReader.java Lines 93-99 (patched) <https://reviews.apache.org/r/61777/#comment259361> It might make sense to split the code into two separate methods for the "case sensitive match" and the "case insensitive match" cases. - Anna Szonyi On Aug. 21, 2017, 9:16 a.m., Zoltán Tóth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61777/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 9:16 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3139 > https://issues.apache.org/jira/browse/SQOOP-3139 > > > Repository: sqoop-trunk > > > Description > ------- > > In the case if the database table name and split-by parameter was different > (eg.: Mycol vs. mycol) Sqoop couldn't continue the query from the last value > if the connection was broken. > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java a78eb061 > src/java/org/apache/sqoop/mapreduce/db/SQLServerDBRecordReader.java > 9a3621b0 > src/test/org/apache/sqoop/mapreduce/db/TestSQLServerDBRecordReader.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61777/diff/1/ > > > Testing > ------- > > > Thanks, > > Zoltán Tóth > >
