> On May 19, 2017, 10:25 a.m., Szabolcs Vasas wrote: > > Hi Sandish, > > > > Thank you for your patch! I wanted to review it in my IDE but I got the > > following error when I tried to apply it: > > > > /Users/szabolcsvasas/Downloads/MergeIncrementalParquetFormat.diff:140: > > trailing whitespace. > > > > /Users/szabolcsvasas/Downloads/MergeIncrementalParquetFormat.diff:224: > > trailing whitespace. > > > > /Users/szabolcsvasas/Downloads/MergeIncrementalParquetFormat.diff:254: > > trailing whitespace. > > > > /Users/szabolcsvasas/Downloads/MergeIncrementalParquetFormat.diff:326: > > trailing whitespace. > > > > /Users/szabolcsvasas/Downloads/MergeIncrementalParquetFormat.diff:330: > > trailing whitespace. > > > > error: patch failed: src/java/org/apache/sqoop/mapreduce/MergeJob.java:19 > > error: src/java/org/apache/sqoop/mapreduce/MergeJob.java: patch does not > > apply > > error: patch failed: src/java/org/apache/sqoop/tool/ImportTool.java:54 > > error: src/java/org/apache/sqoop/tool/ImportTool.java: patch does not apply > > > > Can you please check your patch? > > > > It would be also very good if you could add test coverage. As far as I see > > there are some incremental import related test cases in > > com.cloudera.sqoop.TestIncrementalImport that could help. > > > > Regards, > > Szabolcs > > Sandish Kumar HN wrote: > Thanks for the reply Szabolcs vasas. Sorry for errors inthe pacth. this > is My first time at apache. > Sure I will write few test cases for parquet incremental merge and Which > branch I should be using?? currently Im using "branch-1.4.6"
Hi Sandish, Sorry for the late reply. The new developments should go into the trunk branch. Regards, Szabolcs - Szabolcs ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59346/#review175485 ----------------------------------------------------------- On May 18, 2017, 5:50 p.m., Sandish Kumar HN wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59346/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 5:50 p.m.) > > > Review request for Sqoop, Boglarka Egyed, Attila Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-3178 > https://issues.apache.org/jira/browse/SQOOP-3178 > > > Repository: sqoop-trunk > > > Description > ------- > > New feature for sqoop-1: Sqoop Incremental Merge for Parquet File Format > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/MergeGenericRecordExportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MergeJob.java 4e2a916 > src/java/org/apache/sqoop/mapreduce/MergeParquetMapper.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MergeParquetReducer.java PRE-CREATION > src/java/org/apache/sqoop/tool/ImportTool.java c79e044 > > > Diff: https://reviews.apache.org/r/59346/diff/1/ > > > Testing > ------- > > Hi, > > Currently, sqoop-1 only supports merging of two parquet file format data sets > but it doesn't support to do incremental merge, so I have written a Sqoop > Incremental Merge MR for Parquet File Format and I have tested with million > records of data with N number of iterations. Please review My patch. > > Please let me know if there are any mistakes in My patch > > > Thanks, > > Sandish Kumar HN > >
