Great ideas!

I agree with Bogi and Szabolcs on the redundant test jobs.

Would this pre-commit hook launch the same process as the current
post-commit hook, or would this do something different?
I think in the first case we could rework the post-commit check into the
pre-commit hook, in the latter I'm curious about what exactly this check
would add.
In general I support the idea: we have seen a number of problems that could
have been avoided, so this shall be a very useful change!

Thank you,
Liz

On Fri, Mar 24, 2017 at 9:39 AM, Szabolcs Vasas <va...@cloudera.com> wrote:

> Hi Anna,
>
> Removing the redundant test execution jobs sounds great, I think you can go
> ahead with that.
>
> Regarding the pre-commit hook: what would be the purpose of it exactly?
> Would it execute the unit tests before the patch is committed?
>
> Regards,
> Szabolcs
>
> On Thu, Mar 23, 2017 at 4:03 PM, Anna Szonyi <szo...@cloudera.com> wrote:
>
> > Hi All,
> >
> > I would like to make the following changes to the Sqoop CI system:
> > Disable the SCM polling for the Sqoop-hadoop23 Sqoop-hadoop20 and
> > Sqoop-hadoop100 jobs (and later delete the jobs themselves),
> > as the current trunk version of sqoop no longer contains these profiles,
> so
> > these runs are redundant.
> >
> > I would also like to propose the creation of a pre-commit hook for Sqoop
> > (like the existing one for Sqoop2).
> >
> > Please let me know if you have any objections.
> >
> > Thanks,
> > Anna
> >
>
>
>
> --
> Szabolcs Vasas
> Software Engineer
> <http://www.cloudera.com>
>

Reply via email to