----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57499/#review169361 -----------------------------------------------------------
Hi Jilani, Thanks for your contribution! I have applied your patch and got some warnings because of the incorrect indentation and trailing whitespaces which I mentioned in my review below too, please find my further findings there too. I could run 'ant clean test' susseccfully with your patch. On the top of the findings, could you please add a test case for your change? Thanks, Bogi src/java/org/apache/sqoop/hbase/HBasePutProcessor.java Line 131 (original), 134 (patched) <https://reviews.apache.org/r/57499/#comment241716> Could you please use a more conventional naming to make the code more self-explanatory? I think put should be changed to mutation from now as you are working with mutations instead of puts only. This applies to your whole change in every file too. src/java/org/apache/sqoop/hbase/HBasePutProcessor.java Lines 136-141 (original), 138-154 (patched) <https://reviews.apache.org/r/57499/#comment241717> Something with the indentation went wrong here, Sqoop uses 2 space indentation by default, could you please correct it? Plus there are several trailing white spaces too (marked as red rectangles in Diff). src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java Lines 202 (patched) <https://reviews.apache.org/r/57499/#comment241719> Please correct the indentation here too. src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java Lines 210 (patched) <https://reviews.apache.org/r/57499/#comment241720> Could you please avoid to comment old lines out and remove them instead? src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java Line 84 (original), 86-88 (patched) <https://reviews.apache.org/r/57499/#comment241721> Plese correct the indentation here too. - Boglarka Egyed On March 11, 2017, 6:16 a.m., Jilani Shaik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57499/ > ----------------------------------------------------------- > > (Updated March 11, 2017, 6:16 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3149 > https://issues.apache.org/jira/browse/SQOOP-3149 > > > Repository: sqoop-trunk > > > Description > ------- > > HBase delete is added as part of incremental data import, Modified the return > type of method which is responsible for holding list of Put objects to List > of Mutation objects and at the time of execution of insert or delete using > the type of object in Mutation, executed the actaul operation either insert > or delete. > > Jira ticket for the same: https://issues.apache.org/jira/browse/SQOOP-3149 > > Similar ticket to above: SQOOP-3125 > > > Diffs > ----- > > src/java/org/apache/sqoop/hbase/HBasePutProcessor.java fdbe1276 > src/java/org/apache/sqoop/hbase/PutTransformer.java 533467e5 > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 363e1456 > src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java 58ccee7b > > > Diff: https://reviews.apache.org/r/57499/diff/1/ > > > Testing > ------- > > Executed with jar prepared with these changes into hadoop cluster and tested > bot import and then incremental import. > > > File Attachments > ---------------- > > HBase delete support for incremental import > > https://reviews.apache.org/media/uploaded/files/2017/03/11/5b1895fd-4c6b-42fa-8a92-4e093153e370__hbase_delete_support_in_incremental_import > > > Thanks, > > Jilani Shaik > >
