----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56949/#review166502 -----------------------------------------------------------
Hi Anna, Thank you for the patch. I can see mapred.map.max.attempts constant was defined a couple of times, do you think we could easily remove the duplication and use only one mapreduce.map.max.attempts constant everywhere it is needed? I know it is not necessarily in scope for your patch, but it is worth considering. Regards, Szabolcs - Szabolcs Vasas On Feb. 23, 2017, 8:49 a.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56949/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 8:49 a.m.) > > > Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and > Liz Szilagyi. > > > Bugs: SQOOP-3140 > https://issues.apache.org/jira/browse/SQOOP-3140 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3140: mapred.map.max.attempts, mapred.reduce.max.attempts are > deprecated. Instead, use mapreduce.map.maxattempts, > mapreduce.reduce.maxattempts > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/oracle/OraOopConstants.java 26f1901 > src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 27f84da > src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java > c0c6039 > > Diff: https://reviews.apache.org/r/56949/diff/ > > > Testing > ------- > > ant test > > > Thanks, > > Anna Szonyi > >
