----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54421/#review159154 -----------------------------------------------------------
Fix it, then Ship it! Hi Szabi, Thank you for this clarifying change! I've got only one minor question. src/test/org/apache/sqoop/tool/TestImportTool.java (lines 73 - 80) <https://reviews.apache.org/r/54421/#comment230121> This is a quite big chunk of String manually edited from copy/paste by the looks of it. Wouldn't it be better to store parts of this message in constants and build it up here from the prepared parts? I think it would make it easier to modify later. I think the new ExpectedLogMessage class is especially useful for later enhancements of our tests. Thank you! Liz - Erzsebet Szilagyi On Dec. 6, 2016, 2:57 p.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54421/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 2:57 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3068 > https://issues.apache.org/jira/browse/SQOOP-3068 > > > Repository: sqoop-trunk > > > Description > ------- > > Enhance error (tool.ImportTool: Encountered IOException running import job: > java.io.IOException: Expected schema) to suggest workaround > (--map-column-java) > > > Diffs > ----- > > src/java/org/apache/sqoop/avro/AvroSchemaMismatchException.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/ParquetJob.java b077d9b > src/java/org/apache/sqoop/tool/ImportTool.java ed951ea > src/test/com/cloudera/sqoop/hive/TestHiveImport.java 26d087b > src/test/org/apache/sqoop/tool/TestImportTool.java 4136e9f > src/test/org/apache/sqoop/util/ExpectedLogMessage.java PRE-CREATION > > Diff: https://reviews.apache.org/r/54421/diff/ > > > Testing > ------- > > New integration test and unit test is added. > > > Thanks, > > Szabolcs Vasas > >
