----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53600/#review155803 -----------------------------------------------------------
Hi Anna, Thank you for the contribution and especially for improving on our tests! I have two minor questions, otherwise I support these changes. Thanks, Liz src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java (line 73) <https://reviews.apache.org/r/53600/#comment225894> According to my IDE: "The import org.apache.sqoop.tool.BaseSqoopTool is never used" I know you haven't touched this part, but could you check this please? This is probably a good opportunity for this tiny fix. src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java (line 187) <https://reviews.apache.org/r/53600/#comment225895> The log message "Creating HCatalog table if it exists (...)" doesn't make sense to me. Is it a mistake, or could you explain it to me please? - Erzsebet Szilagyi On Nov. 10, 2016, 5:05 p.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53600/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 5:05 p.m.) > > > Review request for Sqoop and Attila Szabo. > > > Bugs: SQOOP-3027 > https://issues.apache.org/jira/browse/SQOOP-3027 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3027: Added check/fail fast for Sqoop export and import with > --hcatalog-table <HIVE_VIEW>, as it's not supported by Hive + MapReduce (see: > https://cwiki.apache.org/confluence/display/Hive/HCatalog+CLI#HCatalogCLI-Create/Drop/AlterView) > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java ebe7209 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 468bf34 > src/test/org/apache/sqoop/hcat/HCatalogExportTest.java ff3dde1 > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java fe5295a > src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java fb4a200 > > Diff: https://reviews.apache.org/r/53600/diff/ > > > Testing > ------- > > Added unit tests for import, export and view check. Ran ant test. > > > Thanks, > > Anna Szonyi > >
