> On Oct. 24, 2016, 4:14 p.m., Attila Szabo wrote: > > src/java/com/cloudera/sqoop/SqoopOptions.java, lines 46-59 > > <https://reviews.apache.org/r/53134/diff/2/?file=1544216#file1544216line46> > > > > Hi, > > > > This "arg" property does not look very helpful/expressive here. > > > > Could you please rename it like "formatName" or something similar?
Final solution does not contain it. > On Oct. 24, 2016, 4:14 p.m., Attila Szabo wrote: > > src/java/com/cloudera/sqoop/SqoopOptions.java, lines 46-49 > > <https://reviews.apache.org/r/53134/diff/2/?file=1544216#file1544216line46> > > > > I'm a bit concerned here. Do we really want to notify the user with the > > name of the argument instead with the name of the format? > > > > Could you please highlight me the pros? Thanks for the feedback, it was a valid point to think about, I have reverted this change. > On Oct. 24, 2016, 4:14 p.m., Attila Szabo wrote: > > src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java, lines > > 91-144 > > <https://reviews.apache.org/r/53134/diff/2/?file=1544218#file1544218line91> > > > > Could you please squash these for test cases into "one" and instead use > > the DDT capabilities of JUnit to solve the parametrization on that level? Thanks for the idea, I have made a parametrized test case for the failing cases. - Boglarka ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53134/#review153699 ----------------------------------------------------------- On Nov. 6, 2016, 6:01 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53134/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2016, 6:01 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3034 > https://issues.apache.org/jira/browse/SQOOP-3034 > > > Repository: sqoop-trunk > > > Description > ------- > > HBase import should fail fast if using anything other than as-textfile as > those are ignored in the current implementation, however, the user is not > informed about it and the HBase import performs silently as a textfile. > > > Diffs > ----- > > src/java/org/apache/sqoop/tool/BaseSqoopTool.java > 13a9697b2d94e3846f86e1b605cfff3d01dd9347 > src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java > 503a86340f5ae33c8eb0a27b8450b2af0a342db9 > > Diff: https://reviews.apache.org/r/53134/diff/ > > > Testing > ------- > > Test cases have been added for option validation check. > > > Thanks, > > Boglarka Egyed > >
