> On Oct. 20, 2016, 11:56 a.m., Anna Szonyi wrote: > > src/java/org/apache/sqoop/mapreduce/JobBase.java, line 213 > > <https://reviews.apache.org/r/52212/diff/3/?file=1541532#file1541532line213> > > > > Do we only want to check for empty strings? Would it make sense to > > check for whitespaces using .isBlank() instead?
According to org.apache.hadoop.fs.Path.checkPathArg only null and "" are unacceptable. - Erzsebet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52212/#review153371 ----------------------------------------------------------- On Oct. 19, 2016, 5:16 p.m., Erzsebet Szilagyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52212/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 5:16 p.m.) > > > Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna > Szonyi, and Szabolcs Vasas. > > > Bugs: SQOOP-3013 > https://issues.apache.org/jira/browse/SQOOP-3013 > > > Repository: sqoop-trunk > > > Description > ------- > > When setting job configurations and adding files to "tmpjars", Sqoop does not > sanitize the list of empty strings. > Sqoop should remove empty strings before starting the MR job and raise a > warning if an empty string was found. > > The proposed changes check for empty strings in "tmpjars" and remove them > along with raising a warning. > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684 > src/test/org/apache/sqoop/mapreduce/TestJobBase.java PRE-CREATION > > Diff: https://reviews.apache.org/r/52212/diff/ > > > Testing > ------- > > - Live test with command including: "tmpjars=,,valid,,,validother,,," > - Unit tests > > > Thanks, > > Erzsebet Szilagyi > >
