----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50987/#review145606 -----------------------------------------------------------
Fix it, then Ship it! src/java/org/apache/sqoop/manager/DefaultManagerFactory.java (line 28) <https://reviews.apache.org/r/50987/#comment211912> Imports with * option should be avoided according to the community's coding guideline. Sqoop2 coding guideline can be found here: https://cwiki.apache.org/confluence/display/SQOOP/Sqoop+2+Coding+Guidelines which can be considered as Sqoop1 coding guideline as well. src/java/org/apache/sqoop/manager/Manager.java (lines 7 - 9) <https://reviews.apache.org/r/50987/#comment211914> In case of new file creation every file shall contain a head Apache license comment at the beginning of the file. Please check other files for reference, also, you can set a configuration in your IDEA to do it automatically during every file creation. src/test/com/cloudera/sqoop/TestDirectImport.java (lines 14 - 16) <https://reviews.apache.org/r/50987/#comment211917> Please change this to Apache license comment also. src/test/org/apache/sqoop/manager/TestDefaultManagerFactory.java (line 12) <https://reviews.apache.org/r/50987/#comment211918> Please don't use wildcard imports regarding the community's coding guideline. src/test/org/apache/sqoop/manager/TestDefaultManagerFactory.java (lines 14 - 16) <https://reviews.apache.org/r/50987/#comment211919> Please include Apache license comment instead. src/test/org/apache/sqoop/tool/TestValidateImportOptions.java (line 9) <https://reviews.apache.org/r/50987/#comment211921> Please update this, also. src/test/org/apache/sqoop/tool/TestValidateImportOptions.java (lines 11 - 13) <https://reviews.apache.org/r/50987/#comment211920> Change this also, please. - Boglarka Egyed On Aug. 12, 2016, 8:31 a.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50987/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 8:31 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2913 > https://issues.apache.org/jira/browse/SQOOP-2913 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-2913: Make sqoop fail if user uses --direct connector for case when > --direct connector is not available > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/DefaultManagerFactory.java 58ff745 > src/java/org/apache/sqoop/manager/Manager.java PRE-CREATION > src/java/org/apache/sqoop/tool/ImportTool.java ff7b822 > src/test/com/cloudera/sqoop/TestDirectImport.java PRE-CREATION > src/test/org/apache/sqoop/manager/TestDefaultManagerFactory.java > PRE-CREATION > src/test/org/apache/sqoop/tool/TestValidateImportOptions.java PRE-CREATION > > Diff: https://reviews.apache.org/r/50987/diff/ > > > Testing > ------- > > Added new test cases > > > Thanks, > > Anna Szonyi > >
