> On March 11, 2016, 7:26 p.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/util/AppendUtils.java, lines 42-43 > > <https://reviews.apache.org/r/44716/diff/1/?file=1296106#file1296106line42> > > > > For users who are using this property already, we should provide a > > "backward" compatible way. Perhaps the default value in SqoopOptions should > > be System.getProperty("sqoop.test.import.rootDir", "_sqoop"); rather then > > just "_sqoop"?
I've been considering the very same, but I was not sure if we would like to support backward compatibility. Good that you've raised this! - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44716/#review123195 ----------------------------------------------------------- On March 11, 2016, 7:21 p.m., Attila Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44716/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 7:21 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Repository: sqoop-trunk > > > Description > ------- > > Submitted changes for SQOOP-2880 > > > Diffs > ----- > > src/java/org/apache/sqoop/SqoopOptions.java 17751c7 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 50dd67d > src/java/org/apache/sqoop/tool/ImportTool.java ad1d48b > src/java/org/apache/sqoop/util/AppendUtils.java 0102ee7 > src/test/com/cloudera/sqoop/TestSqoopOptions.java f4660e5 > src/test/com/cloudera/sqoop/orm/TestParseMethods.java f222dd7 > > Diff: https://reviews.apache.org/r/44716/diff/ > > > Testing > ------- > > > Thanks, > > Attila Szabo > >
