> On Feb. 2, 2016, 8:54 p.m., Jarek Cecho wrote: > > common/src/main/java/org/apache/sqoop/schema/type/Blob.java, line 20 > > <https://reviews.apache.org/r/42776/diff/2/?file=1221169#file1221169line20> > > > > What is the difference between Blob and Binary? Aren't they the same? > > Colin Ma wrote: > They are not same during the process. To extract the data, the Blob > should be transformed to binary[] as the following code: > Blob blob = resultSet.getBlob(i + 1); > byte[] bytes = blob.getBytes(1, (int)blob.length()); > > For Binary, it's unnecessary.
Got it. Changing our schema objects is however a huge change and should be done "by the way" on JIRA that is meant to add something to our test infrastructure. Let's take this one to a standalone JIRA and let's properly document (explain) why we are doing that. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/#review117465 ----------------------------------------------------------- On Feb. 3, 2016, 7:54 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42776/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 7:54 a.m.) > > > Review request for Sqoop and Colin Ma. > > > Bugs: SQOOP-2797 > https://issues.apache.org/jira/browse/SQOOP-2797 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Add Blob data type support for Derby > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > ae1b60d > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > afc5016 > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java > 8f3e434 > > common-test/src/main/java/org/apache/sqoop/common/test/db/types/DerbyTypeList.java > 642651d > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > 3a3f9e8 > common/src/main/java/org/apache/sqoop/schema/type/Blob.java PRE-CREATION > common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java 9e415bf > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java > 0235f28 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java > a6ffa7c > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > fc25100 > > Diff: https://reviews.apache.org/r/42776/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
