----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38592/#review99985 -----------------------------------------------------------
Ship it! I have few comments, otherwise +1. test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java (lines 81 - 82) <https://reviews.apache.org/r/38592/#comment157043> Let's improve this via separate JIRA since it doesn't seem to be really relevant to this JIRA. test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java (line 140) <https://reviews.apache.org/r/38592/#comment157042> We'll have to drop this change as it has been committed via SQOOP-2584. Jarcec - Jarek Cecho On Sept. 22, 2015, 1:38 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38592/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 1:38 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Update testcases using Jetty instead of Tomcat > > > Diffs > ----- > > test/pom.xml 3e11f59 > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java > 5b4f595 > > test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > 4452558 > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java > 666749b > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java > 1d5b692 > > test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java > be2ac04 > > Diff: https://reviews.apache.org/r/38592/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
