> On March 20, 2015, 2:17 a.m., Abraham Elmahrek wrote: > > LGTM. Is there a Jira for changing how we do table escaping?
Yes: https://issues.apache.org/jira/browse/SQOOP-2244 - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32270/#review77160 ----------------------------------------------------------- On March 20, 2015, 12:13 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32270/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 12:13 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2242 > https://issues.apache.org/jira/browse/SQOOP-2242 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > The patch is a bit bigger in size, but it's rather straighforward in > implementation. Majority is just various renames. > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > e11290b > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > 948431b > common-test/src/main/java/org/apache/sqoop/common/test/db/TableName.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java > d62f585 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java > be95926 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java > 25827f0 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java > eb35b26 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java > 9842754 > test/src/main/java/org/apache/sqoop/test/data/Cities.java 2589061 > test/src/main/java/org/apache/sqoop/test/data/DataSet.java 06f386e > test/src/main/java/org/apache/sqoop/test/data/ShortStories.java 17148bc > test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java 7979686 > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > 80f21cc > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java > 1ba3bd4 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > b454263 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java > 6823ed2 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java > 034ae43 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > 6e1e031 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > b37cdb4 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java > ef9720a > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java > 5ef7c8f > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java > 8a09d7e > > test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java > 1d4e7e6 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > 5f9f41d > > Diff: https://reviews.apache.org/r/32270/diff/ > > > Testing > ------- > > Tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
