-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32275/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2246
    https://issues.apache.org/jira/browse/SQOOP-2246


Repository: sqoop-sqoop2


Description
-------

I've updated the Executor constructor to take entire link configuration object 
rather then few specific arguments. This way any new added configuration 
options will be immediatelly available in the executor without need to add 
another parameter to the constructor.


Diffs
-----

  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
 5af34a5 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java
 3287e16 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
 6ad2cab 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java
 ab1ac86 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java
 e381651 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
 400c0f2 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
 c3b8171 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcTestConstants.java
 67ba5bf 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java
 803d37b 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
 e9c8d41 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java
 2479f89 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
 a61de7d 

Diff: https://reviews.apache.org/r/32275/diff/


Testing
-------

All tests seems to be passing.


Thanks,

Jarek Cecho

Reply via email to