> On Feb. 18, 2015, 11 p.m., Abraham Elmahrek wrote: > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java, > > lines 2026-2035 > > <https://reviews.apache.org/r/31015/diff/3/?file=868245#file868245line2026> > > > > Move this check higher up to keep the repository handler focused on the > > repository? > > Veena Basavaraj wrote: > the only place this needs to do the check is when update method is > called. So do you have more ideas on where is the "higher up"? would help
second, a point I have to mention, this API expects to know who is editing, and this is given from different parts of the code, so even in the worst case as it was discussed in SQOOP-1804, this check should happen in the place, and can happen in "higher up" places as well, so I would keep the same pattern for this as well as in 1804. Please refer to rb on 1804 for more details. - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31015/#review73054 ----------------------------------------------------------- On Feb. 18, 2015, 12:31 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31015/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 12:31 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1516 > https://issues.apache.org/jira/browse/SQOOP-1516 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java > 74e5de3 > common/src/main/java/org/apache/sqoop/model/MConfigType.java fa29d5a > common/src/main/java/org/apache/sqoop/model/MConfigUpdateEntityType.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/model/MLink.java 062a4c5 > common/src/main/java/org/apache/sqoop/model/MMapInput.java ce0f0f7 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 091c3ca > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > f4b1374 > core/src/main/java/org/apache/sqoop/repository/Repository.java e07676a > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 6a23fc2 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > d61ff0b > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > bea5cd7 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java > 6a248e9 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java > 523464b > > Diff: https://reviews.apache.org/r/31015/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
