> On Feb. 19, 2015, 7:20 a.m., Abraham Elmahrek wrote: > > shell/src/main/resources/shell-resource.properties, line 134 > > <https://reviews.apache.org/r/31166/diff/1/?file=868446#file868446line134> > > > > Wonder if it's possible to bold and quote the NAME and ID? See > > 'sqoop.shell_banner' for an example. > > Szehon Ho wrote: > I was able to add the bold via @|bold and |@, but once I added the quote > outside like '@|bold and |@' it blew up and displayed just {0} and {1}. I > guess it can quote a literal but not a variable in this way. Do you have any > idea, I couldn't find many docs about how to do this syntax? Thanks.
No idea... was just an idea... bolding alone seems cool! - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31166/#review73094 ----------------------------------------------------------- On Feb. 18, 2015, 11:54 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31166/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 11:54 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2117 > https://issues.apache.org/jira/browse/SQOOP-2117 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Currently it shows id, which is not helpful unless user shows the connectors > as well. > > This patch during 'show link' make another call on the client side to get > connector info, which more often than not should be cached (such as when the > link is created). > > > Diffs > ----- > > shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java e92f0b4 > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 46f2b7f > shell/src/main/resources/shell-resource.properties 9c88235 > > Diff: https://reviews.apache.org/r/31166/diff/ > > > Testing > ------- > > Manually tested > > > Thanks, > > Szehon Ho > >
