----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23514/#review47985 -----------------------------------------------------------
src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java <https://reviews.apache.org/r/23514/#comment84242> While the function cannot throw an error (because the statement executed is a deterministic one that does not touch any physical table), there can be situations where this can fail and we will only log an error saying we could not get the user and fail later during processing. The chances are very remote but I would say non-zero. That said, I realized, I had duplicated the code from what I wrote for OracleManager (the default one) and now that the Oracle High performance connector is part of Sqoop proper, it does not make sense to duplicate the code. I have removed the duplicated code in the OraoopConnManager and reused the one OracleManager and updated it throw a RuntimeException in the even username could not be retrieved. - Venkat Ranganathan On July 16, 2014, 7:01 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23514/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 7:01 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1358 > https://issues.apache.org/jira/browse/SQOOP-1358 > > > Repository: sqoop-trunk > > > Description > ------- > > Added support to understand wallet based JDBC URLS that was done to standard > Oracle connector. This was done earlier in the HWX repo. > > Made sure no new checkstyle violations exist > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 302849c > src/java/org/apache/sqoop/manager/oracle/OraOopConstants.java 874ef02 > src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java 8502b79 > src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java fcf4a4d > src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java 473a5ae > > Diff: https://reviews.apache.org/r/23514/diff/ > > > Testing > ------- > > Created Oracle wallet as described in > https://blogs.apache.org/sqoop/entry/using_oracle_wallets_with_sqoop > > Used the wallet in a sqoop job with --direct passed to the command line > arguments to make use of the high performance connector and validated it. > > > Thanks, > > Venkat Ranganathan > >
