> On July 10, 2014, 8:22 a.m., Venkat Ranganathan wrote: > > src/java/org/apache/sqoop/manager/MainframeManager.java, line 75 > > <https://reviews.apache.org/r/22516/diff/1/?file=608148#file608148line75> > > > > Is import into Hbase and Accumulo supported by this tool? It looks > > like the only target supported is HDFS text files from the command help. > > Mariappan Asokan wrote: > Each record in a mainframe dataset is treated as a single field (or > column.) So, theoretically HBase, Accumulo, and Hive are supported but with > limited usability. So, I did not add them in the documentation. If you feel > strongly that they should be documented, I can work on that in the next > version of the patch.
I feel it would be good to say we import only as text files and leave further processing, loading into hive/hbase upto the user as the composition of the records and needed processing differ and the schema can't be inferred. > On July 10, 2014, 8:22 a.m., Venkat Ranganathan wrote: > > src/java/org/apache/sqoop/manager/MainframeManager.java, line 62 > > <https://reviews.apache.org/r/22516/diff/1/?file=608148#file608148line62> > > > > Very Minor nits: We have a few lines with trailing blanks. IT would > > be great to fix them so that we can reduce more checkstyle errors creeping > > in. ant checkstyle target can be used to identify the issues reported and > > fix > > Mariappan Asokan wrote: > I will fix these minor nits in the next version of the patch. Thanks > On July 10, 2014, 8:22 a.m., Venkat Ranganathan wrote: > > src/java/org/apache/sqoop/manager/MainframeManager.java, line 85 > > <https://reviews.apache.org/r/22516/diff/1/?file=608148#file608148line85> > > > > Same question as HBaseTable > > Mariappan Asokan wrote: > Please see my answer above. Thanks > On July 10, 2014, 8:22 a.m., Venkat Ranganathan wrote: > > src/java/org/apache/sqoop/manager/MainframeManager.java, line 122 > > <https://reviews.apache.org/r/22516/diff/1/?file=608148#file608148line122> > > > > Minor nit: Spaces between type and array declaration will be flagged > > by checkstyle also > > Mariappan Asokan wrote: > I will fix this. Thanks - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22516/#review47555 ----------------------------------------------------------- On June 14, 2014, 10:46 p.m., Mariappan Asokan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22516/ > ----------------------------------------------------------- > > (Updated June 14, 2014, 10:46 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > This is to move mainframe datasets to Hadoop. > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/MainframeManager.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MainframeDatasetFTPRecordReader.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MainframeDatasetImportMapper.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MainframeDatasetInputFormat.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MainframeDatasetInputSplit.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MainframeDatasetRecordReader.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/MainframeImportJob.java PRE-CREATION > src/java/org/apache/sqoop/tool/MainframeImportTool.java PRE-CREATION > src/java/org/apache/sqoop/tool/SqoopTool.java dbe429a > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java PRE-CREATION > src/test/org/apache/sqoop/manager/TestMainframeManager.java PRE-CREATION > > src/test/org/apache/sqoop/mapreduce/TestMainframeDatasetFTPRecordReader.java > PRE-CREATION > src/test/org/apache/sqoop/mapreduce/TestMainframeDatasetInputFormat.java > PRE-CREATION > src/test/org/apache/sqoop/mapreduce/TestMainframeDatasetInputSplit.java > PRE-CREATION > src/test/org/apache/sqoop/mapreduce/TestMainframeImportJob.java > PRE-CREATION > src/test/org/apache/sqoop/tool/TestMainframeImportTool.java PRE-CREATION > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22516/diff/ > > > Testing > ------- > > > Thanks, > > Mariappan Asokan > >
