On Feb. 26, 2014, 6:37 p.m., David Robson wrote: > > Jarcec
Adding to Jarcec's comments, Since there are some functionality issue differences (for example timestamp handling) we may need to continue to have a backward-compatible mode (something similar to what Oraoop currently has). I would also say that we rearrange the code so that it more or less fits into the new organization - org.apache.sqoop.mapreduce/org.apache.sqoop.mapreduce.db etc. One idea may be to make the OraOop a "direct" Oracle connection manager. That way we can integrate it better. - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18452/#review35545 ----------------------------------------------------------- On Feb. 25, 2014, 3:24 a.m., David Robson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18452/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 3:24 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1287 > https://issues.apache.org/jira/browse/SQOOP-1287 > > > Repository: sqoop-trunk > > > Description > ------- > > Dell Software is contributing an Oracle connector for the Sqoop project. > This is an initial patch to get early feedback - it is not finished. At the > moment it is just the code itself - no tests or documentation. > There is still more work to do in the code - checkstyle and findbugs has not > been resolved as yet. > > > Diffs > ----- > > src/java/org/apache/sqoop/ConnFactory.java 61d3307 > src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopConstants.java PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopDBRecordReader.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopDataDrivenDBInputFormat.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopGenerics.java PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopJdbcUrl.java PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopLog.java PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopLogFactory.java PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopLogMessage.java PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopManagerFactory.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java > PRE-CREATION > > src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatBase.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatInsert.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatUpdate.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OracleActiveInstance.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OracleConnectionFactory.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OracleTable.java PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OracleTableColumn.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OracleTableColumns.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OracleTablePartition.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OracleTablePartitions.java > PRE-CREATION > src/java/org/apache/sqoop/manager/oracle/OracleVersion.java PRE-CREATION > > Diff: https://reviews.apache.org/r/18452/diff/ > > > Testing > ------- > > > Thanks, > > David Robson > >
