[ https://issues.apache.org/jira/browse/SQOOP-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803756#comment-13803756 ]
Hari Shreedharan commented on SQOOP-1189: ----------------------------------------- Nice catch. Patch looks good. I think there can be some parameterization done in the MAccountableEntity, MConnection and MJob classes to avoid so much similar repeated code - but that is for another day, and not within the scope of this jira. > Sqoop2: Ensure that clone methods will correctly copy over all values from > all parents > -------------------------------------------------------------------------------------- > > Key: SQOOP-1189 > URL: https://issues.apache.org/jira/browse/SQOOP-1189 > Project: Sqoop > Issue Type: Improvement > Affects Versions: 1.99.2 > Reporter: Jarek Jarcec Cecho > Assignee: Jarek Jarcec Cecho > Attachments: bugSQOOP-1189.patch > > > I've noticed that currently metadata upgrade is loosing data as variables > from {{MAccountableEntity}} are not carried over during upgrade. We should > enhance the model classes to make their cloning easier, so that it won't be > that easy to forget to copy come values from parent classes. -- This message was sent by Atlassian JIRA (v6.1#6144)