----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13839/#review25901 -----------------------------------------------------------
Looks good. Regarding the support for custom compression format, I think we can track it as part of a separate JIRA. Do you agree Jarcec? Thanks Venkat - Venkat Ranganathan On Sept. 3, 2013, 9:56 p.m., Raghav Gautam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13839/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 9:56 p.m.) > > > Review request for Sqoop. > > > Bugs: sqoop-1182 > https://issues.apache.org/jira/browse/sqoop-1182 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Exposing compression options for Sqoop2 > > > Diffs > ----- > > > core/src/main/java/org/apache/sqoop/framework/configuration/OutputCompression.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/framework/configuration/OutputForm.java > 3cb9499 > core/src/main/resources/framework-resources.properties cebc90e > > execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java > 767080c > > execution/mapreduce/src/test/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngineTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/13839/diff/ > > > Testing > ------- > > Added unit tests. > Manually tested. > > > Thanks, > > Raghav Gautam > >
