Could you file a JIRA issue with the description of your steps, Martin? Dongjoon.
On 2025/05/05 10:32:13 Martin Grund wrote: > Not sure this counts as -1, but by cursory checking the code, I found that > the way the TLS connection is set up is not always working: > > https://github.com/apache/spark-connect-swift/blob/v0.1.0-rc1/Sources/SparkConnect/DataFrame.swift#L276-L288 > > Shows that DataFrame operations explicitly set plaintext despite the actual > client being configured using TLS. > > The current implementation works OK for local plaintext connections, but > will not work for a connection with TLS because it will try to establish to > different connections in the same block in the execute() logic. The > interplay between withGRPC() and execute() causes this issue. > > > On Mon, May 5, 2025 at 10:12 AM Gabor Somogyi <gabor.g.somo...@gmail.com> > wrote: > > > +1 (non-binding) > > > > G > > > > On Mon, May 5, 2025 at 8:35 AM huaxin gao <huaxin.ga...@gmail.com> wrote: > > > >> +1 Thanks Dongjoon. > >> > >> On Sun, May 4, 2025 at 5:21 PM Dongjoon Hyun <dongj...@apache.org> wrote: > >> > >>> +1 > >>> > >>> I checked the checksum and signatures, and tested with Apache Spark > >>> 4.0.0 RC4 on Swift 6.1. > >>> > >>> This is the initial release (v0.1) with 105 patches to provide a > >>> tangible release to the users. > >>> > >>> v0.2 is under planning in SPARK-51999. > >>> > >>> Dongjoon. > >>> > >>> On 2025/05/04 22:14:54 Dongjoon Hyun wrote: > >>> > Please vote on releasing the following candidate as Apache Spark > >>> Connect > >>> > Swift Client 0.1.0. This vote is open for the next 72 hours and passes > >>> if a > >>> > majority +1 PMC votes are cast, with a minimum of 3 +1 votes. > >>> > > >>> > [ ] +1 Release this package as Apache Spark Connect Swift Client 0.1.0 > >>> > [ ] -1 Do not release this package because ... > >>> > > >>> > TAG: > >>> > https://github.com/apache/spark-connect-swift/releases/tag/v0.1.0-rc1 > >>> > (commit: e1e8a327ce13d53ecaa4b7c2a5e8d69ffb822940) > >>> > > >>> > RELEASE FILES: > >>> > > >>> https://dist.apache.org/repos/dist/dev/spark/spark-connect-swift-v0.1.0-rc1/ > >>> > > >>> > LIST OF ISSUES: > >>> > https://issues.apache.org/jira/projects/SPARK/versions/12355780 > >>> > > >>> > Thanks, > >>> > Dongjoon. > >>> > > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org > >>> > >>> > --------------------------------------------------------------------- To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
