Yes I think it should be okay to move. A little bit check of history - the method was introduced in https://github.com/apache/spark/pull/7813, where at that time, it’s being used by SortBasedAggregationIterator and UnsafeHybridAggregationIterator. But right now UnsafeHybridAggregationIterator is refactored away and no longer exists.
Cheng Su From: Jacek Laskowski <ja...@japila.pl> Date: Tuesday, May 25, 2021 at 6:35 AM To: dev <dev@spark.apache.org> Subject: Should AggregationIterator.initializeBuffer be moved down to SortBasedAggregationIterator? Hi, Just found out that the only purpose of AggregationIterator.initializeBuffer is to keep SortBasedAggregationIterator happy [1]. Shouldn't it be moved down to SortBasedAggregationIterator to make things clear(er)? [1] https://github.com/apache/spark/search?q=initializeBuffer Pozdrawiam, Jacek Laskowski ---- https://about.me/JacekLaskowski<https://about.me/JacekLaskowski> "The Internals Of" Online Books<https://books.japila.pl/> Follow me on https://twitter.com/jaceklaskowski<https://twitter.com/jaceklaskowski> <https://twitter.com/jaceklaskowski>
