SGTM. Thanks for the work! +1 (non-binding)
On Wed, May 26, 2021 at 1:28 AM Dongjoon Hyun <dongjoon.h...@gmail.com> wrote: > Thank you, Sean and Gengliang. > > To Gengliang, it looks not that serious to me because that's a doc-only > issue which also can be mitigated simply by updating `facetFilters` from > htmls after release. > > Bests, > Dongjoon. > > > On Tue, May 25, 2021 at 9:45 AM Gengliang Wang <ltn...@gmail.com> wrote: > >> Hi Dongjoon, >> >> After Spark 3.1.1, we need an extra step for updating the DocSearch >> version index in the release process. I didn't expect Spark 3.1.2 to come >> at this time so I haven't updated the release process >> <https://github.com/apache/spark-website/pull/344> until yesterday. >> I think we should use the latest branch-3.1 to regenerate the Spark >> documentation. See https://github.com/apache/spark/pull/32654 for >> details. I have also enhanced the release process script >> <https://github.com/apache/spark/pull/32662> for this. >> >> Thanks >> Gengliang >> >> >> >> >> On Tue, May 25, 2021 at 11:31 PM Sean Owen <sro...@apache.org> wrote: >> >>> +1 same result as in previous tests >>> >>> On Mon, May 24, 2021 at 1:14 AM Dongjoon Hyun <dongjoon.h...@gmail.com> >>> wrote: >>> >>>> Please vote on releasing the following candidate as Apache Spark >>>> version 3.1.2. >>>> >>>> The vote is open until May 27th 1AM (PST) and passes if a majority +1 >>>> PMC votes are cast, with a minimum of 3 +1 votes. >>>> >>>> [ ] +1 Release this package as Apache Spark 3.1.2 >>>> [ ] -1 Do not release this package because ... >>>> >>>> To learn more about Apache Spark, please see https://spark.apache.org/ >>>> >>>> The tag to be voted on is v3.1.2-rc1 (commit >>>> de351e30a90dd988b133b3d00fa6218bfcaba8b8): >>>> https://github.com/apache/spark/tree/v3.1.2-rc1 >>>> >>>> The release files, including signatures, digests, etc. can be found at: >>>> https://dist.apache.org/repos/dist/dev/spark/v3.1.2-rc1-bin/ >>>> >>>> Signatures used for Spark RCs can be found in this file: >>>> https://dist.apache.org/repos/dist/dev/spark/KEYS >>>> >>>> The staging repository for this release can be found at: >>>> https://repository.apache.org/content/repositories/orgapachespark-1384/ >>>> >>>> The documentation corresponding to this release can be found at: >>>> https://dist.apache.org/repos/dist/dev/spark/v3.1.2-rc1-docs/ >>>> >>>> The list of bug fixes going into 3.1.2 can be found at the following >>>> URL: >>>> https://issues.apache.org/jira/projects/SPARK/versions/12349602 >>>> >>>> This release is using the release script of the tag v3.1.2-rc1. >>>> >>>> FAQ >>>> >>>> ========================= >>>> How can I help test this release? >>>> ========================= >>>> >>>> If you are a Spark user, you can help us test this release by taking >>>> an existing Spark workload and running on this release candidate, then >>>> reporting any regressions. >>>> >>>> If you're working in PySpark you can set up a virtual env and install >>>> the current RC and see if anything important breaks, in the Java/Scala >>>> you can add the staging repository to your projects resolvers and test >>>> with the RC (make sure to clean up the artifact cache before/after so >>>> you don't end up building with a out of date RC going forward). >>>> >>>> =========================================== >>>> What should happen to JIRA tickets still targeting 3.1.2? >>>> =========================================== >>>> >>>> The current list of open tickets targeted at 3.1.2 can be found at: >>>> https://issues.apache.org/jira/projects/SPARK and search for "Target >>>> Version/s" = 3.1.2 >>>> >>>> Committers should look at those and triage. Extremely important bug >>>> fixes, documentation, and API tweaks that impact compatibility should >>>> be worked on immediately. Everything else please retarget to an >>>> appropriate release. >>>> >>>> ================== >>>> But my bug isn't fixed? >>>> ================== >>>> >>>> In order to make timely releases, we will typically not hold the >>>> release unless the bug in question is a regression from the previous >>>> release. That being said, if there is something which is a regression >>>> that has not been correctly targeted please ping me or a committer to >>>> help target the issue. >>>> >>>