Why not just use SLF4J? On Tue, Feb 3, 2015 at 2:22 PM, Reynold Xin <r...@databricks.com> wrote: > We can use ScalaTest's privateMethodTester also instead of exposing that. > > On Tue, Feb 3, 2015 at 2:18 PM, Marcelo Vanzin <van...@cloudera.com> wrote: > >> Hi Jay, >> >> On Tue, Feb 3, 2015 at 6:28 AM, jayhutfles <jayhutf...@gmail.com> wrote: >> > // Exposed for testing >> > private[spark] var printStream: PrintStream = System.err >> >> > But as the comment states that it's for testing, maybe I'm >> > misunderstanding its intent... >> >> The comment is there to tell someone reading the code that this field >> is a `var` and not private just because test code (SparkSubmitSuite in >> this case) needs to modify it, otherwise it wouldn't exist or would be >> private. Similar in spirit to this annotation: >> >> >> http://guava-libraries.googlecode.com/svn/tags/release09/javadoc/com/google/common/annotations/VisibleForTesting.html >> >> (Which I'd probably have used in this case, but is not really common >> in Spark code.) >> >> -- >> Marcelo >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org >> For additional commands, e-mail: dev-h...@spark.apache.org >> >>
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org For additional commands, e-mail: dev-h...@spark.apache.org
