On Thu, Nov 13, 2014 at 10:58 AM, Patrick Wendell <pwend...@gmail.com> wrote: >> That's true, but note the code I posted activates a profile based on >> the lack of a property being set, which is why it works. Granted, I >> did not test that if you activate the other profile, the one with the >> property check will be disabled. > > Ah yeah good call - I so then we'd trigger 2.11-vs-not based on the > presence of -Dscala-2.11. > > Would that fix this issue then? It might be a simpler fix to merge > into the 1.2 branch than Sandy's patch since we're pretty late in the > game (though that patch does other things separately that I'd like to > see end up in Spark soon).
Yeah, that's the idea. As for simplicity, I think Sandy's patch would be just as simple if it avoided all the changes to isolate the examples / external stuff into different profiles. -- Marcelo --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org For additional commands, e-mail: dev-h...@spark.apache.org
