One way to do this would be to have a Github hook that parses -1s or +1s and posts a commit status [1] (like say Travis [2]) right next to the PR. Does anybody know of an existing tool that does this ?
Shivaram [1] https://github.com/blog/1227-commit-status-api [2] http://blog.travis-ci.com/2012-09-04-pull-requests-just-got-even-more-awesome/ On Mon, Jul 21, 2014 at 1:44 PM, Kay Ousterhout <k...@eecs.berkeley.edu> wrote: > Hi all, > > As the number of committers / contributors on Spark has increased, there > are cases where pull requests get merged before all the review comments > have been addressed. This happens say when one committer points out a > problem with the pull request, and another committer doesn't see the > earlier comment and merges the PR before the comment has been addressed. > This is especially tricky for pull requests with a large number of > comments, because it can be difficult to notice early comments describing > blocking issues. > > This also happens when something accidentally gets merged after the tests > have started but before tests have passed. > > Do folks have ideas on how we can handle this issue? Are there other > projects that have good ways of handling this? It looks like for Hadoop, > people can -1 / +1 on the JIRA. > > -Kay >
