Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/144#issuecomment-37714253
  
    Yeah sorry, I didn't mean leave out max and min from StatCounter, I just 
meant that the RDD.max() and RDD.min() methods should directly call reduce. If 
you're calling those (instead of RDD.stats()), you only want one of the values, 
so there's no need to compute the others.
    
    @dwmclary, thanks for the update. I made a few small comments but the final 
thing missing would be to update the Scala StatCounter class with max and min 
fields as well -- it doesn't currently have them, but you added them to Python. 
Sorry it's a bit of a pain to maintain consistency across these.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to