Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/42#discussion_r10616395
--- Diff: core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala ---
@@ -22,24 +22,25 @@ import java.text.SimpleDateFormat
import java.util.{Date, Properties}
import java.util.concurrent.LinkedBlockingQueue
-import scala.collection.mutable.{HashMap, HashSet, ListBuffer}
+import scala.collection.mutable.HashMap
import org.apache.spark._
import org.apache.spark.executor.TaskMetrics
-import org.apache.spark.rdd.RDD
-import org.apache.spark.storage.StorageLevel
/**
* A logger class to record runtime information for jobs in Spark. This
class outputs one log file
- * for each Spark job, containing RDD graph, tasks start/stop, shuffle
information.
- * JobLogger is a subclass of SparkListener, use addSparkListener to add
JobLogger to a SparkContext
- * after the SparkContext is created.
- * Note that each JobLogger only works for one SparkContext
- * @param logDirName The base directory for the log files.
+ * for each Spark job, containing tasks start/stop and shuffle
information. JobLogger is a subclass
+ * of SparkListener, use addSparkListener to add JobLogger to a
SparkContext after the SparkContext
+ * is created. Note that each JobLogger only works for one SparkContext
+ *
+ * NOTE: The functionality of this class is heavily stripped down to
accommodate for a general
+ * refactor of the SparkListener interface. In its place, the
EventLoggingListener is introduced
+ * to log application information as SparkListenerEvents through the
SparkUI. To enable this
--- End diff --
Previously it does in the sense that if you don't create a SparkUI then it
definitely won't log events. With your suggested changes, it no longer does it
"through the SparkUI"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
