Github user dwmclary commented on the pull request:

    https://github.com/apache/spark/pull/122#issuecomment-37666086
  
    Prashant,
    
      Thanks for the review!  I'll break out the min/max bit and submit a PR 
for 1246 later today and then just leave the histogram bit on 1170.
    
    Cheers,
    Dan
    
    Sent from my iPhone
    
    On Mar 14, 2014, at 5:33 AM, Prashant Sharma <notificati...@github.com> 
wrote:
    
    > Hi Daniel,
    > 
    > Thanks for the patch,
    > 
    > It would be good to separate out the implementation of min max into a 
different PR and provide Rdd.min and RDD.max functions too. Also assign it a 
JIRA SPARK-1246. Thought of asking you since you have it already in this PR. 
Part of it is done in #140 for java and scala.
    > 
    > Prashant.
    > 
    > —
    > Reply to this email directly or view it on GitHub.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to