Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/126#discussion_r10549758
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1025,6 +1025,14 @@ abstract class RDD[T: ClassTag](
         checkpointData.flatMap(_.getCheckpointFile)
       }
     
    +  def cleanup() {
    +    logInfo("Cleanup called on RDD " + id)
    +    sc.cleaner.cleanRDD(this)
    +    dependencies.filter(_.isInstanceOf[ShuffleDependency[_, _]])
    --- End diff --
    
    This is probably not important, but a while loop would be much faster here. 
This would likely only be a problem if the dependency list was very long or 
many RDDs were being cleaned up simultaneously (an ML or streaming program, 
perhaps). Feel free to not change this if you feel that the code change is not 
worth the performance benefit here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to