Github user yaoshengzhe commented on the pull request:

    https://github.com/apache/spark/pull/126#issuecomment-37475144
  
    @Tathagata, I am strongly disagree to put cleanup logic in finalize. 
Finalizers are unpredictable, often dangerous, and generally unnecessary, e.g. 
there is a severe performance penalty for using finalizers for object creation 
and destroy, please see 
http://www.informit.com/articles/article.aspx?p=1216151&seqNum=7 for more 
details. 
    
    I would suggest to call RDD.cleanup explicitly once we know it is no longer 
being used.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to