Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/126#issuecomment-37357590
Hey TD, I just glanced at this quickly, but I have two small suggestions
with the way you are using finalizers. First, errors in finalizers aren't
reported by the GC thread, so it might be good to wrap everything in a try with
some of our own logging for errors. Second, this is probably not an issue ATM,
but it might be a good idea to call super.finalize(), just incase other objects
up the tree are relying on this being called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
