Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/42#discussion_r10363792
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -978,6 +971,11 @@ class DAGScheduler(
           logDebug("Additional executor lost message for " + execId +
                    "(epoch " + currentEpoch + ")")
         }
    +    // Block manager master actor should not be null except during tests
    +    if (blockManagerMaster.driverActor != null) {
    +      val storageStatusList = blockManagerMaster.getStorageStatus
    +      
listenerBus.post(SparkListenerExecutorsStateChange(storageStatusList))
    --- End diff --
    
    Hm ya @andrewor14 is there a reason the storage status needs to be updated 
here? Logging the global storage status is pretty expensive. I figured maybe it 
was because if an executor fails the blocks could get re-replicated. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to