Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/42#discussion_r10361480
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -27,28 +28,58 @@ import org.apache.spark.ui.jobs.JobProgressUI
import org.apache.spark.ui.storage.BlockManagerUI
import org.apache.spark.util.Utils
-/** Top level user interface for Spark */
-private[spark] class SparkUI(sc: SparkContext) extends Logging {
- val host =
Option(System.getenv("SPARK_PUBLIC_DNS")).getOrElse(Utils.localHostName())
- val port = sc.conf.get("spark.ui.port", SparkUI.DEFAULT_PORT).toInt
- var boundPort: Option[Int] = None
- var server: Option[Server] = None
+/** Top level user interface for Spark. */
+private[spark] class SparkUI(val sc: SparkContext, conf: SparkConf, port:
Int) extends Logging {
- val handlers = Seq[(String, Handler)](
+ def this(sc: SparkContext) =
+ this(sc, sc.conf, sc.conf.get("spark.ui.port",
SparkUI.DEFAULT_PORT).toInt)
+
+ // Persisted UI constructors
+ def this(conf: SparkConf, port: Int) = this(null, conf, port)
+ def this(conf: SparkConf) =
--- End diff --
Are these two constructors ever used?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
