GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/69
Remove broken/unused Connection.getChunkFIFO method.
This method appears to be broken -- since it never removes
anything from messages, and it adds new messages to it,
the while loop is an infinite loop. The method also does not appear
to have ever been used since the code was added in 2012, so
this commit removes it.
cc @mateiz who originally added this method in case there's a reason it
should be here!
(https://github.com/apache/spark/commit/63051dd2bcc4bf09d413ff7cf89a37967edc33ba)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kayousterhout/spark-1 remove_get_fifo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit 053bc59fda89370e067e7f83afb572e6bb131c7b
Author: Kay Ousterhout <kayousterh...@gmail.com>
Date: 2014-03-04T00:01:10Z
Remove broken/unused Connection.getChunkFIFO method.
This method appears to be broken -- since it never removes
anything from messages, and it adds new messages to it,
the while loop is an infinite loop. The method also does not appear
to have ever been used since the code was added in 2012, so
this commit removes it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
