[
https://issues.apache.org/jira/browse/SLING-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982140#comment-16982140
]
Ashish Chopra commented on SLING-8853:
--------------------------------------
PR (without SLING-8854 changes since that's still under discussion) as at
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/24.
[~marett], I tried to implement an IT for {{ActiveResourceQueue}} based on
existing {{ResourceQueueIT}}, but I couldn't even get the existing test to run
successfully.
I updated pom.xml of the project with diff as at [0] (had to lower the version
of m-f-p as mentioned at [1] to avoid "forked VM terminated" error). Even after
that, I see error as at [2] when running the ITs.
Can you please guide me on how to run existing Pax Exam tests in the
sling-distribution-core bundle?
[0]
{code}
diff --git a/pom.xml b/pom.xml
index 6e50d20..c2689ec 100644
--- a/pom.xml
+++ b/pom.xml
@@ -135,13 +135,37 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
+ <version>2.18.1</version>
+ <executions>
+ <execution>
+ <goals>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ </execution>
+ </executions>
<configuration>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
<includes>
<include>**/*IT.java</include>
</includes>
+ <redirectTestOutputToFile>true</redirectTestOutputToFile>
</configuration>
- </plugin>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.servicemix.tooling</groupId>
+ <artifactId>depends-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>generate-depends-file</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+
<outputFile>${project.build.directory}/test-classes/META-INF/maven/dependencies.properties</outputFile>
+ </configuration>
+ </plugin>
</plugins>
</build>
{code}
[1]
http://karaf.922171.n3.nabble.com/Pax-exam-tests-fail-to-start-properly-with-Karaf-4-0-4-tp4044841p4044845.html
[2]
{code}
Running org.apache.sling.distribution.queue.impl.resource.ResourceQueueIT
Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 382.193 sec <<<
FAILURE! - in org.apache.sling.distribution.queue.impl.resource.ResourceQueueIT
testExecute(org.apache.sling.distribution.queue.impl.resource.ResourceQueueIT)
Time elapsed: 14.375 sec <<< ERROR!
org.ops4j.pax.exam.TestContainerException: There are unresolved bundles. See
previous ERROR log messages for details.
at
org.ops4j.pax.exam.forked.ForkedTestContainer.verifyThatBundlesAreResolved(ForkedTestContainer.java:345)
at
org.ops4j.pax.exam.forked.ForkedTestContainer.installAndStartBundles(ForkedTestContainer.java:309)
at
org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:165)
at
org.ops4j.pax.exam.spi.reactors.AllConfinedStagedReactor.invoke(AllConfinedStagedReactor.java:79)
at
org.ops4j.pax.exam.junit.impl.ProbeRunner$2.evaluate(ProbeRunner.java:267)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:98)
at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
testFifo(org.apache.sling.distribution.queue.impl.resource.ResourceQueueIT)
Time elapsed: 183.63 sec <<< ERROR!
org.ops4j.pax.exam.TestContainerException: start level 5 has not been reached
within 180000 ms
at
org.ops4j.pax.exam.forked.ForkedTestContainer.setFrameworkStartLevel(ForkedTestContainer.java:324)
at
org.ops4j.pax.exam.forked.ForkedTestContainer.installAndStartBundles(ForkedTestContainer.java:308)
at
org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:165)
at
org.ops4j.pax.exam.spi.reactors.AllConfinedStagedReactor.invoke(AllConfinedStagedReactor.java:79)
at
org.ops4j.pax.exam.junit.impl.ProbeRunner$2.evaluate(ProbeRunner.java:267)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:98)
at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
testConcurrentFifo(org.apache.sling.distribution.queue.impl.resource.ResourceQueueIT)
Time elapsed: 183.944 sec <<< ERROR!
org.ops4j.pax.exam.TestContainerException: start level 5 has not been reached
within 180000 ms
at
org.ops4j.pax.exam.forked.ForkedTestContainer.setFrameworkStartLevel(ForkedTestContainer.java:324)
at
org.ops4j.pax.exam.forked.ForkedTestContainer.installAndStartBundles(ForkedTestContainer.java:308)
at
org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:165)
at
org.ops4j.pax.exam.spi.reactors.AllConfinedStagedReactor.invoke(AllConfinedStagedReactor.java:79)
at
org.ops4j.pax.exam.junit.impl.ProbeRunner$2.evaluate(ProbeRunner.java:267)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.ops4j.pax.exam.junit.impl.ProbeRunner.run(ProbeRunner.java:98)
at org.ops4j.pax.exam.junit.PaxExam.run(PaxExam.java:93)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Results :
Tests in error:
ResourceQueueIT.testConcurrentFifo » TestContainer start level 5 has not
been ...
ResourceQueueIT.testExecute » TestContainer There are unresolved bundles.
See ...
ResourceQueueIT.testFifo » TestContainer start level 5 has not been reached
wi...
Tests run: 3, Failures: 0, Errors: 3, Skipped: 0
{code}
> Develop an Active variant of ResourceQueue and make it available as possible
> queue.provider for ForwardDistributionAgentFactory
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-8853
> URL: https://issues.apache.org/jira/browse/SLING-8853
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
> Reporter: Ashish Chopra
> Assignee: Timothee Maret
> Priority: Major
> Fix For: Content Distribution Core 0.4.2
>
> Attachments:
> 0001-SLING-8853-Adds-ActiveResourceQueue-and-makes-it-ava.patch,
> 0003-SLING-8853-SLING-8854-enabling-ActiveResourceQueue-t.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Via SLING-7754, a JCR Resource-backed queue [0] implementation was developed
> for usecases where a queue processor wasn't required, {{ResourceQueue}}
> implementation is currently {{PASSIVE}}.
> Given above, it is not possible to leverage {{ResourceQueue}} as a
> {{queue.provider}} for {{DistributionAgents}} created via
> {{ForwardDistributionAgentFactory}} [1].
> This issue aims to add an "Active" variant of Resource backed queues and
> provide it as an option for {{ForwardDistributionAgentFactory}}.
> [0]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceQueue.java
> [1]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/deb3d2ae33c4f4678c8503091a9fffdbb141e569/src/main/java/org/apache/sling/distribution/agent/impl/ForwardDistributionAgentFactory.java#L171-L178
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
