[ 
https://issues.apache.org/jira/browse/SLING-8396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833841#comment-16833841
 ] 

Simone Tripodi commented on SLING-8396:
---------------------------------------

what happens is that the {{core}} artifacts contains multiple 
{{META-INF/maven/${groupId}/${artifactId}/pom.properties}} declaration:

{noformat}
$ jar -tvf 
/private/tmp/sling-content-2-feature-issue/core/target/core-1.0.0-SNAPSHOT.jar 
     0 Mon May 06 13:25:22 CEST 2019 META-INF/
  1990 Mon May 06 13:25:22 CEST 2019 META-INF/MANIFEST.MF
 11560 Thu Jan 13 23:06:36 CET 2011 META-INF/LICENSE.txt
   178 Thu Jan 13 23:06:36 CET 2011 META-INF/NOTICE.txt
     0 Mon May 06 13:25:22 CEST 2019 META-INF/maven/
     0 Mon May 06 13:25:22 CEST 2019 META-INF/maven/com.madplanet.sling.cp2sf/
     0 Mon May 06 13:25:22 CEST 2019 
META-INF/maven/com.madplanet.sling.cp2sf/core/
   148 Mon May 06 13:25:22 CEST 2019 
META-INF/maven/com.madplanet.sling.cp2sf/core/pom.properties
  6394 Mon May 06 13:24:14 CEST 2019 
META-INF/maven/com.madplanet.sling.cp2sf/core/pom.xml
     0 Mon May 06 13:25:22 CEST 2019 META-INF/maven/commons-lang/
     0 Mon May 06 13:25:22 CEST 2019 META-INF/maven/commons-lang/commons-lang/
   112 Thu Jan 13 23:06:52 CET 2011 
META-INF/maven/commons-lang/commons-lang/pom.properties
 17494 Thu Jan 13 23:05:12 CET 2011 
META-INF/maven/commons-lang/commons-lang/pom.xml
{noformat}

the bundle handler was designed taking in mind that each maven artifact 
contains only ONE {{pom.properties}},
we don't have implemented any heuristic ATM to guess GAV from the artifact file 
name, we did something smart in the {{ApisJarMojo}}, let me see if I can 
implement something smarter rather than just taking all the matching 
properties...

> Sling Content Package to Feature Model fails with embedded Bundles
> ------------------------------------------------------------------
>
>                 Key: SLING-8396
>                 URL: https://issues.apache.org/jira/browse/SLING-8396
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>    Affects Versions: Feature Model Converter 1.0.0
>         Environment: Apache Sling 11, Mac OS X 10.13.6, Java 8
>            Reporter: Andreas Schaefer
>            Assignee: Simone Tripodi
>            Priority: Major
>
> When a content package contains an embedded bundle the bundle will not be 
> listed inside the generated FM json file if content package requires more 
> than one bundle.
> I have an ui.apps content package that has a bundle which is not provided and 
> one embedded bundle (core). The not provided bundle is listed in the json 
> file but the core is missing.
> If I have a content package with just the embedded bundle it is listed there.
> Failing json file:
> {code:json}
> {
>   "id":"com.peregrine-cms:base.ui.apps:slingosgifeature:1.0-SNAPSHOT",
>   "description":"JCR Package for the Peregrine CMS Platform including\n       
>  the Platform Core bundle.",
>   "bundles":[
>     {
>       "id":"org.apache.sling:org.apache.sling.servlet-helpers:1.1.8",
>       "start-order":"20"
>     }
>   ],
> {code}
>  
> Working json file:
> {code:json}
> {
>   "id":"com.peregrine-cms:felib.ui.apps:slingosgifeature:1.0-SNAPSHOT",
>   "description":"JCR Package for the Peregrine CMS Felib module.",
>   "bundles":[
>     {
>       "id":"com.peregrine-cms:felib.core:1.0-SNAPSHOT",
>       "start-order":"20"
>     }
>   ],
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to