[ 
https://issues.apache.org/jira/browse/SLING-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792450#comment-16792450
 ] 

Konrad Windszus edited comment on SLING-8314 at 3/14/19 8:24 AM:
-----------------------------------------------------------------

Please consider also the discussion at 
https://www.mail-archive.com/[email protected]/msg83978.html. Also I assume 
that the write back of a primitive array (lowercase prefix type) only happens 
if the underlying metatype definition for that attribute has a positive 
cardinality (compare with 
https://osgi.org/specification/osgi.cmpn/7.0.0/service.metatype.html#org.osgi.service.metatype.annotations.AttributeType).
Since OSGi Configuration Admin allows
# primitive arrays
# object arrays and 
# collection of objects 

all three should be properly supported by the write-back feature (i.e. a 
round-trip via the write back should not change the underlying dictionary).

This issue is actually fixed already with SLING-6247 (i.e. OSGi Installer 
support for lowercase type prefixes).


was (Author: kwin):
Please consider also the discussion at 
https://www.mail-archive.com/[email protected]/msg83978.html. Also I assume 
that the write back of a primitive array (lowercase prefix type) only happens 
if the underlying metatype definition for that attribute has a positive 
cardinality (compare with 
https://osgi.org/specification/osgi.cmpn/7.0.0/service.metatype.html#org.osgi.service.metatype.annotations.AttributeType).
Since OSGi Configuration Admin allows both primitive arrays and Collection of 
classes IMHO also both should be supported by the write-back feature.

This issue is actually fixed already with SLING-6247 (i.e. OSGi Installer 
support for lowercase type prefixes).

> JCR Installer writeback  - primitive array types get lower case prefix , 
> convert primitive arrays to Object arrays  
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-8314
>                 URL: https://issues.apache.org/jira/browse/SLING-8314
>             Project: Sling
>          Issue Type: Bug
>          Components: Installer
>    Affects Versions: JCR Installer 3.1.26
>            Reporter: Ashok Kumar
>            Priority: Major
>
> When we put a upper case prefix in our config in the repo and then change it 
> via the webconsole it gets the prefix converted into a lower case. This 
> creates issues as Sling only support uppercase prefixes.
> As the writeback just uses some class from Felix to write the file back (that 
> will write a lower case for primitive arrays and an upper case for Object 
> arrays) the fix should be reasonable straight forward by just massaging the 
> configurations before writing them out via that class and turning all 
> primitive arrays into their respective Object array in updatehandler.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to