rombert commented on issue #1: SLING-8266 - Stop embedding ESAPI URL: https://github.com/apache/sling-org-apache-sling-scripting-jsp-taglib/pull/1#issuecomment-462271378 After adapting the tests I see that two checks are failing ``` Failed tests: TestEncodeTag.testEncode:185 expected:<&amp[;Hello World!]> but was:<&amp[;Hello World!]> TestSlingFunctions.testEncode:90 expected:<&nbsp[;Here is some text!]> but was:<&nbsp[;Here is some text!]> ``` It looks like the encoding functions were more eager in the taglib setup but are more relaxed in the XSS API bundle ( e.g. don't encode `!` ). I would suggest to adapt the tests to use the form returned by the XSS API as it brings the encoding close to Sling behaviour in general.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
