bosschaert commented on issue #4: SLING-7932 - Use Regex to parse mvn GAVs and URLs URL: https://github.com/apache/sling-org-apache-sling-feature/pull/4#issuecomment-428486353 Hi @simonetripodi I like the unit tests in this pull request, but I'm wondering about the code changes. I'm not entirely sure the regex are that much better/easier than what was there before. And they are most likely not faster. I would be inclined to take just the tests from this pull request (assuming they work with the current code) and leave the actual code changes the way they are...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
