rishabhdaim commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/5#issuecomment-5092510748
> Thanks for working on splitting the commits @rishabhdaim . I see that [75cf0a5](https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/commit/75cf0a54ad22e7f214731d1c4611598f7ec15c68) still has too many changes, it has whitespace + unrelated fixes. > > It's fine to add all of the fixes into this PR to make sure that the project builds, but please use this structure: > > * one commit only with the parent POM update (right now has too many changes) > > * one only with the reformatting (some of the formatting changes are not included here) > > * one with ignoring the commit for blame (already done) > > * any follow-up fixes should be different commits (some are in the first commit that updates the parent pom) @rombert addressed all review comments in the latest commits. Please review when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
