joerghoh commented on PR #73: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/73#issuecomment-3977643558
From what I see the code effectively just changes the name of the threadpools for the * DistributionPackageBuilderFactory and * VaultDistributionPackageBuilderFactory both of them are not mentioned in https://issues.apache.org/jira/browse/SLING-11026, and the classes mentioned in the ticket are not part of the PR. While for VaultDistributionPackageBuilderFactory the change is in line with the intention of SLING-11026 (not using the default threadpool anymore), this PR changes the threadpool for DistributionPackageBuilderFactory. Interestingly the title of this PR mentions ResourceDistributionPackageCleanup, but this class is not included in the PR. I wonder why I see all this just now (a bit late), but I am not really happy with the current state of this PR. My suggestion: * Please close this PR and create a new PR * this new PR should contain the changes for the 4 classes mentioned in the ticket plus VaultDistributionPackageBuilderFactory (I wonder why I haven't listed it). * and then let's discuss the impact when switching the threadpool for DistributionPackageBuilderFactory, and if it makes sense to switch all all scheduled jobs in this bundle to the same threadpool (then we can argue if it we should chose a new name or reuse the existing one ...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
