kwin commented on code in PR #16:
URL:
https://github.com/apache/sling-org-apache-sling-installer-core/pull/16#discussion_r2840825663
##########
src/main/java/org/apache/sling/installer/core/impl/tasks/RestartActiveBundlesTask.java:
##########
@@ -49,6 +49,15 @@ public RestartActiveBundlesTask(final TaskResourceGroup erl,
final TaskSupport s
if (ids == null) {
ids = new HashSet<Long>();
}
+ final Set<Long> fragmentIds = new HashSet<>();
Review Comment:
Why do we need this twice? During constructor we remove fragments and during
execute we skip as well. Isn't this redundant? I would recommend doing it only
during `execute()` and log skipping with level INFO/WARN as IMHO the problem is
rather that this task is triggered in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
