kwin commented on code in PR #67: URL: https://github.com/apache/sling-parent/pull/67#discussion_r2832607253
########## sling-parent/pom.xml: ########## Review Comment: Let's upgrade this as well: https://github.com/palantir/palantir-java-format/releases/tag/2.88.0 ########## sling-parent/pom.xml: ########## @@ -107,7 +107,7 @@ <properties> <site.jira.version.id>12313945</site.jira.version.id> <site.javadoc.exclude /> - <junit5.version>5.14.2</junit5.version> + <junit5.version>5.14.3</junit5.version> Review Comment: What about using JUnit6 (the new major version is primarily to express that it requires Java 17 which shouldn't be an issue in this context) in sling-bundle-parent: https://docs.junit.org/6.0.2/release-notes.html#v6.0.0, that anyhow already requires that version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
