stefan-egli commented on code in PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-standalone/pull/1#discussion_r2254316004


##########
src/main/java/org/apache/sling/discovery/impl/standalone/NoClusterDiscoveryService.java:
##########
@@ -118,10 +127,17 @@ private void createNewView(final Type eventType, boolean 
inform) {
             final InstanceDescription myInstanceDescription = new 
InstanceDescriptionImpl(this.settingsService.getSlingId(),
                     this.cachedProperties);
             this.currentTopologyView = new 
TopologyViewImpl(myInstanceDescription);
+            
+            // If always offline is enabled, mark the topology as not current
+            if (this.alwaysOffline) {
+                this.currentTopologyView.setNotCurrent();

Review Comment:
   is there a particular reason for introducing `setNotCurrent` or would 
reusing `invalidate` be an option too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to