scottyuancoc commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-scripting-javascript/pull/10#issuecomment-3151301585
Hello @rombert, I missed the earlier comment from @joerghoh regarding the potential issue in the ScriptableBase code (see [SLING-12873](https://issues.apache.org/jira/browse/SLING-12873)). It’s definitely something that should be addressed. That said, I agree it makes sense to keep getNative() as a single-threaded access implementation for now. I’ve pushed an update to ensure getNative() remains single-threaded, and I’ve added a comment in the code to document this behavior. @joerghoh, thank you for reporting the finding. I am looking at providing another PR for [SLING-12873](https://issues.apache.org/jira/browse/SLING-12873) with test cases to verify the situation. Do feel free to forward the task over if it make sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
